util: add JoinQueue data structure #7590
Open
+349
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickkuk
force-pushed
the
join_deque
branch
3 times, most recently
from
2068e58 to
bab83ad
Compare
ADD-SP
reviewed
Sep 9, 2025
ADD-SP
reviewed
Sep 9, 2025
ADD-SP
added
C-enhancement
ADD-SP
reviewed
Sep 10, 2025
ADD-SP
added
the
S-waiting-on-author
nickkuk
force-pushed
the
join_deque
branch
2 times, most recently
from
2c34aef to
837875d
Compare
Ok, I pushed implementation of all methods except |
ADD-SP
reviewed
Sep 11, 2025
nickkuk
changed the title
Darksonn
reviewed
Sep 11, 2025
| /// | ||
| /// [`join_next`]: fn@Self::join_next | ||
| /// [`JoinError::id`]: fn@tokio::task::JoinError::id | ||
| pub async fn join_all(mut self) -> Vec<T> { |
There was a problem hiding this comment.
All async functions must have a cancel safety section in the documentation.
Comment on lines
+270
to
+273
| // A JoinHandle generally won't emit a wakeup without being ready unless | ||
| // the coop limit has been reached. We yield to the executor in this | ||
| // case. | ||
| cx.waker().wake_by_ref(); |
There was a problem hiding this comment.
This is wrong because self.0.front_mut() is not the same as the pop_notified() used by JoinSet. Since you always poll a JoinHandle no matter what, you should not call wake_by_ref() here. This will cause needless spinning.
Please add a test that would have caught this bug. You can look at tests using tokio_test::spawn for examples of how you can detect whether wakeups are sent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
tokio_util::task::JoinQueuestructure as FIFO-ordered analog oftokio::task::JoinSet.Issue: #7576
Edit: renamed from
JoinDequetoJoinQueue.